Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(footer): v2 layout updates #11110

Merged
merged 10 commits into from
Nov 13, 2023
Merged

feat(footer): v2 layout updates #11110

merged 10 commits into from
Nov 13, 2023

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Nov 8, 2023 •
edited
Loading

Related Ticket(s)

Closes #11090

Description

New layout for adjunct links and moving locale button below
Screenshot 2023-11-08 at 8 53 49 AM

add IBM logo to micro footer
Screenshot 2023-11-08 at 8 54 25 AM

Changelog

New

  • refactoring of styles and slots to allow for different layout for all different size variations
  • added new ibm logo

@ariellalgilmore ariellalgilmore added package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2 labels Nov 8, 2023
@ariellalgilmore ariellalgilmore added the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Nov 8, 2023
@ariellalgilmore ariellalgilmore marked this pull request as ready for review November 8, 2023 18:09
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner November 8, 2023 18:09
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 8, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11110/index.html

Built with commit: be3f21c8f1129d2508832201c4cce9c8ad0ec1a6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 8, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11110/index.html

Built with commit: be3f21c8f1129d2508832201c4cce9c8ad0ec1a6

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 8, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11110/index.html

Built with commit: be3f21c8f1129d2508832201c4cce9c8ad0ec1a6

kennylam
kennylam reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ariellalgilmore! Just one small change, I think.

kennylam
kennylam approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oliviaflory
Copy link
Contributor

oliviaflory commented Nov 10, 2023 •
edited by RichKummer
Loading

@ariellalgilmore this looks really good, a few small updates:

  • Can we update the two adjunct links copy to the following:

    • Updated terms of use
    • React learning technologies

  • The mico footer looks a bit larger than the short footer when you view them in the small breakpoint, but they are the same size in the specs, maybe a spacing carry over from v1.

Micro short
Screenshot 2023-11-09 at 8 19 27 PM Screenshot 2023-11-09 at 8 11 24 PM
  • I think the legal links look a bit too spaced out compared to the specs, it looks like Rich has them 8px apart to match the links in the default footer
Screenshot 2023-11-09 at 8 16 40 PM Screenshot 2023-11-09 at 8 17 01 PM

@ariellalgilmore
Copy link
Member Author

@oliviaflory updated!!

RichKummer
RichKummer reviewed Nov 10, 2023
View reviewed changes
Copy link

@RichKummer RichKummer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariellalgilmore this looks so good 💪
Couple of details that could be fixed up:

Global

  • When @sm, the last accordion of the footer links doesn't have a border at the bottom.
Screenshot 2023-11-10 at 3 24 17 PM

Default

  • When @md, the nav group loses their headings. This looks like the only breakpoint with this issue.
  • Noticed that there's an 8px extra bit of spacing that looks like it's coming from a hidden Cookie preferences option. It adds a bit extra to the bottom spacing which is otherwise right. I only see this with the bottom of legal links not the adjunct links.
Screenshot 2023-11-10 at 3 10 29 PM Screenshot 2023-11-10 at 3 10 40 PM

@ariellalgilmore
Copy link
Member Author

Thanks @RichKummer ! just pushed updates, but weird i'm not seeing the issue on md breakpoint where the headers go away
Screenshot 2023-11-10 at 1 57 27 PM

@RichKummer
Copy link

@ariellalgilmore super weird with the headings, but I'm seeing them again based on the last updates 🤔

Everything checks out, but I did notice that for some reason the micro version has the links float upwards a bit – these should be centered vertically in the div:

Current build:
Screenshot 2023-11-13 at 11 10 02 AM

Design:
Screenshot 2023-11-13 at 11 15 46 AM

RichKummer
RichKummer approved these changes Nov 13, 2023
View reviewed changes
Copy link

@RichKummer RichKummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome @ariellalgilmore ! 💯 💯 💯

@oliviaflory oliviaflory removed the Needs design approval PRs on feature requests and new components have to get design approval before merge. label Nov 13, 2023
@ariellalgilmore ariellalgilmore merged commit fca0adc into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Nov 13, 2023
1 of 5 checks passed
@ariellalgilmore ariellalgilmore deleted the feat/footer-v2-updates branch November 13, 2023 20:28
@RichKummer RichKummer mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichKummer RichKummer RichKummer approved these changes

@kennylam kennylam kennylam approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@oliviaflory oliviaflory Awaiting requested review from oliviaflory

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package v2: prep preparation items for Carbon for IBM.com V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ariellalgilmore @ibmdotcom-bot @oliviaflory @RichKummer @kennylam