Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(content-group-pictograms): screen reader issue fix #11099

Merged
merged 2 commits into from
Nov 7, 2023
Merged

fix(content-group-pictograms): screen reader issue fix #11099

merged 2 commits into from
Nov 7, 2023

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #9655

Description

Screen reader does not identify icons near the links

Changelog

New

  • Empty title tag added for the svg element (Since it's not an Img tag adding alt="" was not possible.)

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner November 6, 2023 11:43
@sangeethababu9223 sangeethababu9223 added dev Needs some dev work accessibility Has accessibility requirement package: web components Work necessary for the IBM.com Library web components package labels Nov 6, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 6, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11099/index.html

Built with commit: ac767a6bea5e03666c3dfbf849afc3cf131adf5b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 6, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11099/index.html

Built with commit: ac767a6bea5e03666c3dfbf849afc3cf131adf5b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 6, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11099/index.html

Built with commit: ac767a6bea5e03666c3dfbf849afc3cf131adf5b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 6, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11099/index.html

Built with commit: ac767a6bea5e03666c3dfbf849afc3cf131adf5b

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Nov 6, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11099/index.html

Built with commit: ac767a6bea5e03666c3dfbf849afc3cf131adf5b

kennylam
kennylam approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Nov 7, 2023
@kodiakhq kodiakhq bot merged commit c42a71f into carbon-design-system:main Nov 7, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
accessibility Has accessibility requirement dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Content group pictograms]: QA: Screen reader does not identify icons near the links
3 participants
@sangeethababu9223 @ibmdotcom-bot @kennylam