Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-flags): implement feature flags for cwc #11081

Merged
merged 2 commits into from
Nov 1, 2023
Merged

feat(feature-flags): implement feature flags for cwc #11081

merged 2 commits into from
Nov 1, 2023

Conversation

annawen1
Copy link
Member

Related Ticket(s)

Closes #11048

Description

Add file to house feature flags and set up storybook to hide experimental components from being displayed.

Once the feature flag is defined in feature-flags.ts, we'll use it in the render() method of the component

import { CDS_EXPERIEMENTAL_COMPONENT_NAME } from '../../globals/internal/feature-flags';

....

render() {
    return CDS_EXPERIEMENTAL_COMPONENT_NAME
      ? html`
          <ol class="${classes}">
            <slot></slot>
          </ol>
        `
      : null;
  }

Changelog

New

  • feature-flags.ts to house the flags
  • copied over logic from dotcom web-components storybook to hide experimental components' stories from the storybook UI

@annawen1 annawen1 requested a review from a team as a code owner October 31, 2023 15:44
@annawen1 annawen1 requested review from kennylam and emyarod October 31, 2023 15:44
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 31, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11081/index.html

Built with commit: 5b54e73506f43b5f096c0b86440ad54c07d1de20

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 31, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11081/index.html

Built with commit: 5b54e73506f43b5f096c0b86440ad54c07d1de20

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 31, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11081/index.html

Built with commit: 5b54e73506f43b5f096c0b86440ad54c07d1de20

@annawen1 annawen1 linked an issue Oct 31, 2023 that may be closed by this pull request
[cwc feature-flags]: add feature flag capabilities #11048
Closed
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 31, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11081/index.html

Built with commit: 5b54e73506f43b5f096c0b86440ad54c07d1de20

ariellalgilmore
ariellalgilmore approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@annawen1 annawen1 added the feature flag: cwc used to trigger cwc experimental deploy previews label Oct 31, 2023
@annawen1 annawen1 closed this Oct 31, 2023
@annawen1 annawen1 reopened this Oct 31, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 31, 2023 •
edited
Loading

Deploy preview created for package "Carbon Web Components (experimental)":
https://carbon-web-components-experimental.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11081/index.html

Built with commit: 5b54e73506f43b5f096c0b86440ad54c07d1de20

@annawen1 annawen1 merged commit 9b0c96d into carbon-design-system:feat/cwc-v2 Nov 1, 2023
11 of 23 checks passed
@annawen1 annawen1 deleted the feat/cwc-feature-flags branch November 1, 2023 16:18
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@annawen1
feat(feature-flags): implement feature flags for cwc (carbon-design-s…
7a3f99c 
…ystem#11081)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@emyarod emyarod Awaiting requested review from emyarod emyarod was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
feature flag: cwc used to trigger cwc experimental deploy previews package: carbon web components v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cwc feature-flags]: add feature flag capabilities
3 participants
@annawen1 @ibmdotcom-bot @ariellalgilmore