Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-selector): remove internal decorator #11069

Merged
merged 2 commits into from
Oct 26, 2023
Merged

fix(language-selector): remove internal decorator #11069

merged 2 commits into from
Oct 26, 2023

Conversation

kennylam
Copy link
Member

Related Ticket(s)

Closes #10885

Description

Removes the @internal decorator from language-selector which was preventing output to the .d.ts. Also removes unneeded code from bx-input.

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • @internal decorator
  • unused getter/setter from bx-input

@kennylam kennylam added the package: web components Work necessary for the IBM.com Library web components package label Oct 26, 2023
@kennylam kennylam requested a review from a team as a code owner October 26, 2023 18:58
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11069/index.html

Built with commit: aa2280ab371d40fdaa6361858fcf0dec61054519

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 26, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11069/index.html

Built with commit: aa2280ab371d40fdaa6361858fcf0dec61054519

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11069/index.html

Built with commit: aa2280ab371d40fdaa6361858fcf0dec61054519

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11069/index.html

Built with commit: aa2280ab371d40fdaa6361858fcf0dec61054519

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11069/index.html

Built with commit: aa2280ab371d40fdaa6361858fcf0dec61054519

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Oct 26, 2023
@kodiakhq kodiakhq bot merged commit d61199d into carbon-design-system:main Oct 26, 2023
24 of 25 checks passed
@kennylam kennylam deleted the fix/language-selector-10885 branch October 26, 2023 20:36
kennylam added a commit that referenced this pull request Oct 28, 2023
@kennylam
fix(language-selector): remove internal decorator (#11069)
5525ab9 
### Related Ticket(s)

Closes #10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Dec 4, 2023
@kennylam
fix(language-selector): remove internal decorator (carbon-design-syst…
2c601c5 
…em#11069)

### Related Ticket(s)

Closes carbon-design-system#10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@kennylam kennylam mentioned this pull request Dec 19, 2023
Closed
2 tasks
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@kennylam
fix(language-selector): remove internal decorator (carbon-design-syst…
edfaa29 
…em#11069)

### Related Ticket(s)

Closes carbon-design-system#10885 

### Description

Removes the `@internal` decorator from `language-selector` which was preventing output to the `.d.ts`. Also removes unneeded code from `bx-input`.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- `@internal` decorator
- unused getter/setter from `bx-input`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Carbon for IBM.com and Angular
3 participants
@kennylam @ibmdotcom-bot @annawen1