10921: add aria-label to anchor tags inside bx-tabs for accessbility #11047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
added
bug
|
Deploy preview created for package Built with commit: c08cea3f1a516a00b418474a3e1ebab5facf0b3d |
|
Deploy preview created for package Built with commit: c08cea3f1a516a00b418474a3e1ebab5facf0b3d |
|
Deploy preview created for package Built with commit: c08cea3f1a516a00b418474a3e1ebab5facf0b3d |
|
Deploy preview created for package Built with commit: c08cea3f1a516a00b418474a3e1ebab5facf0b3d |
|
Deploy preview created for package Built with commit: c08cea3f1a516a00b418474a3e1ebab5facf0b3d |
kennylam
approved these changes
Oct 25, 2023
|
Thanks @kennylam ! Now that I am working as an outside contributer, is it up to me to merge or for someone on your side? |
kennylam
added
Ready to merge
kodiakhq
bot
merged commit 7f51280
into
carbon-design-system:main
24 of 25 checks passed
kennylam
pushed a commit
that referenced
this pull request
Oct 28, 2023
…11047) ### Related Ticket(s) Closes #10921 ### Description This PR adds `aria-label` to the <a> tags inside of `bx-tab` component. Since the text inside the <a> tags is in a slot in the shadow dom, the links are being flagged for not having meaningful text. This PR fixes that. ### Changelog **Changed** - Adds `aria-label` with the link text to <a> tags inside bx-tab component. ### Steps for testing 1. Navigate to [Tabs in Carbon Web Components](https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11047/index.html?path=/story/components-tabs--default). 2. Click Open Canvas in New Tab box in upper left. 3. Have IBM Equal Access Accessibility checker installed as Chrome extension. Scan the page. 4. Note the lack of the original accessibility fail ("Interactive component with ARIA role 'tab' does not have a programmatically associated name"). 5. Compare by following the same steps at [Carbon Web Components v1 storybook](https://web-components-v1.carbondesignsystem.com/?path=/story/components-tabs--default). <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Dec 4, 2023
…arbon-design-system#11047) ### Related Ticket(s) Closes carbon-design-system#10921 ### Description This PR adds `aria-label` to the <a> tags inside of `bx-tab` component. Since the text inside the <a> tags is in a slot in the shadow dom, the links are being flagged for not having meaningful text. This PR fixes that. ### Changelog **Changed** - Adds `aria-label` with the link text to <a> tags inside bx-tab component. ### Steps for testing 1. Navigate to [Tabs in Carbon Web Components](https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11047/index.html?path=/story/components-tabs--default). 2. Click Open Canvas in New Tab box in upper left. 3. Have IBM Equal Access Accessibility checker installed as Chrome extension. Scan the page. 4. Note the lack of the original accessibility fail ("Interactive component with ARIA role 'tab' does not have a programmatically associated name"). 5. Compare by following the same steps at [Carbon Web Components v1 storybook](https://web-components-v1.carbondesignsystem.com/?path=/story/components-tabs--default). <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…arbon-design-system#11047) ### Related Ticket(s) Closes carbon-design-system#10921 ### Description This PR adds `aria-label` to the <a> tags inside of `bx-tab` component. Since the text inside the <a> tags is in a slot in the shadow dom, the links are being flagged for not having meaningful text. This PR fixes that. ### Changelog **Changed** - Adds `aria-label` with the link text to <a> tags inside bx-tab component. ### Steps for testing 1. Navigate to [Tabs in Carbon Web Components](https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11047/index.html?path=/story/components-tabs--default). 2. Click Open Canvas in New Tab box in upper left. 3. Have IBM Equal Access Accessibility checker installed as Chrome extension. Scan the page. 4. Note the lack of the original accessibility fail ("Interactive component with ARIA role 'tab' does not have a programmatically associated name"). 5. Compare by following the same steps at [Carbon Web Components v1 storybook](https://web-components-v1.carbondesignsystem.com/?path=/story/components-tabs--default). <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #10921
Description
This PR adds
aria-labelto the tags inside ofbx-tabcomponent. Since the text inside the tags is in a slot in the shadow dom, the links are being flagged for not having meaningful text. This PR fixes that.Changelog
Changed
aria-labelwith the link text to tags inside bx-tab component.Steps for testing