Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): focus trap issue fix in v2 #11040

Closed
wants to merge 10 commits into from
Closed

fix(modal): focus trap issue fix in v2 #11040

wants to merge 10 commits into from

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #10966

Description

Focus trap not working in Modal

Changelog

New

  • Added Modal footer button to tabbable items in settings.js

Changed

  • Updated condition for focus trapping

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner October 16, 2023 15:40
@sangeethababu9223 sangeethababu9223 linked an issue Oct 16, 2023 that may be closed by this pull request
[Modal]: Focus trapping not working #10966
Closed
2 tasks
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11040/index.html

Built with commit: a34cd787fe32705ee2659e068f6cf57871acf534

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11040/index.html

Built with commit: a34cd787fe32705ee2659e068f6cf57871acf534

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11040/index.html

Built with commit: a34cd787fe32705ee2659e068f6cf57871acf534

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 16, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11040/index.html

Built with commit: a34cd787fe32705ee2659e068f6cf57871acf534

@sangeethababu9223 sangeethababu9223 changed the base branch from feat/cwc-v2 to feat/carbon-for-ibm-dotcom-v2 November 23, 2023 04:31
@sangeethababu9223 sangeethababu9223 changed the base branch from feat/carbon-for-ibm-dotcom-v2 to feat/cwc-v2 November 23, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod Awaiting requested review from emyarod emyarod was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
dev Needs some dev work package: carbon web components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Modal]: Focus trapping not working
2 participants
@sangeethababu9223 @ibmdotcom-bot