Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(content-block): make content-block an internal component #11019

Merged
merged 4 commits into from
Oct 11, 2023
Merged

chore(content-block): make content-block an internal component #11019

merged 4 commits into from
Oct 11, 2023

Conversation

annawen1
Copy link
Member

Related Ticket(s)

Closes #10752

Description

Remove content-block stories so the component becomes an internal component

Changelog

Removed

  • content-block stories

@annawen1 annawen1 added package: web components Work necessary for the IBM.com Library web components package v2 labels Oct 10, 2023
@annawen1 annawen1 requested a review from a team as a code owner October 10, 2023 13:14
@annawen1 annawen1 changed the base branch from main to feat/carbon-for-ibm-dotcom-v2 October 10, 2023 13:14
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 10, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11019/index.html

Built with commit: 9dce775ef2feb0f02ce821ce8546266e95c51ad0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 10, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11019/index.html

Built with commit: 9dce775ef2feb0f02ce821ce8546266e95c51ad0

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 10, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11019/index.html

Built with commit: 9dce775ef2feb0f02ce821ce8546266e95c51ad0

@kennylam kennylam merged commit 33dc7a3 into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Oct 11, 2023
@kennylam kennylam deleted the feat/content-block-v2 branch October 11, 2023 19:58
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Oct 17, 2023
@annawen1 @kennylam
feat(content-block): make content-block an internal component (carbon…
6b0dd37 
…-design-system#11019)

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] Content block (internal)
3 participants
@annawen1 @ibmdotcom-bot @kennylam