Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(link-with-icon): upgrade v2 styles #11009

Merged
merged 3 commits into from
Oct 11, 2023
Merged

feat(link-with-icon): upgrade v2 styles #11009

merged 3 commits into from
Oct 11, 2023

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Oct 5, 2023

Related Ticket(s)

Closes #10859

Description

Update link-with-icon styles and tokens to Carbon v11

Changelog

New

  • {{new thing}}

Changed

  • Use Carbon v11 styles/tokens
  • move web component-specific styles to styles package

Removed

  • {{removed thing}}

@kennylam kennylam added package: web components Work necessary for the IBM.com Library web components package v2 labels Oct 5, 2023
@kennylam kennylam requested a review from a team as a code owner October 5, 2023 22:34
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 5, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11009/index.html

Built with commit: ce18b38863614820b13118951c06f7e7f24aa37e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 5, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11009/index.html

Built with commit: ce18b38863614820b13118951c06f7e7f24aa37e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 5, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11009/index.html

Built with commit: ce18b38863614820b13118951c06f7e7f24aa37e

IgnacioBecerra
IgnacioBecerra approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam merged commit f45a4fe into carbon-design-system:feat/carbon-for-ibm-dotcom-v2 Oct 11, 2023
3 of 7 checks passed
@kennylam kennylam deleted the feat/link-with-icon-v2-10859 branch October 11, 2023 19:27
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Oct 17, 2023
@kennylam
feat(link-with-icon): upgrade v2 styles (carbon-design-system#11009)
be32e53 
* feat(link-with-icon): upgrade to v2 styles

* chore(docs): update migration docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kennylam @ibmdotcom-bot @IgnacioBecerra