fix(date picker): detect change range interval console error #11532
Conversation
sangeethababu9223
requested review from
kennylam and
emyarod
and removed request for
a team
|
Deploy preview created for package Built with commit: ee42c61bafee4c4af063e9b9147d3e88d97cb0a5 |
|
Deploy preview created for package Built with commit: ee42c61bafee4c4af063e9b9147d3e88d97cb0a5 |
|
Deploy preview created for package Built with commit: ee42c61bafee4c4af063e9b9147d3e88d97cb0a5 |
|
Deploy preview created for package Built with commit: ee42c61bafee4c4af063e9b9147d3e88d97cb0a5 |
There was a problem hiding this comment.
Looks like what happened between when I last worked on this up until now is that, v2 was merged and it reverted flatpickr from the version I had updated it to, 4.6.13, back to 4.1.6.
I don't have a strong opinion, ultimately we'll likely want to drop flatpickr eventually b/c it's not well maintained, but another option is to set flatpickr to 4.6.13 (note we have patches to make it all work). Once set to 4.6.13, everything should work the same as v1.
If we keep this change as is, which I kinda like b/c less code we're maintaining, don't need patches, and seems to work well, we should remove the patch for 4.6.13.
kennylam
added
Ready to merge
kodiakhq
bot
merged commit eee2c73
into
carbon-design-system:main
|
Hey there! This issue/pull request was referenced in recently released v2.5.0. |
…design-system#11532) Closes carbon-design-system#11490 In Date picker element, dev tool console shows error `Uncaught TypeError: fp.getDateStr is not a function`. **Removed** - Removed custom event handling function. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…design-system#11532) Closes carbon-design-system#11490 In Date picker element, dev tool console shows error `Uncaught TypeError: fp.getDateStr is not a function`. **Removed** - Removed custom event handling function. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
…design-system#11532) ### Related Ticket(s) Closes carbon-design-system#11490 ### Description In Date picker element, dev tool console shows error `Uncaught TypeError: fp.getDateStr is not a function`. ### Changelog **Removed** - Removed custom event handling function. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Related Ticket(s)
Closes #11490
Description
In Date picker element, dev tool console shows error
Uncaught TypeError: fp.getDateStr is not a function.Changelog
Removed