Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datatable): is-sortable not working with table column cell #11516

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11474

Description

Passing is-sortable to <cds-table-header-cell> makes the column unsortable.
Column being unsortble is already fixed with PR
But clicking on the sort icon makes all the columns sortable, this is fixed.

Changelog

Changed

  • expandable and is-selectable attributes mapped to proper variables. This was affecting the sorting action on individual columns.
  • Updated the sort action to check if only specific columns are made sortable with is-sortable attribute and if so prevent other columns from showing sort icon.

@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra added the Ready to merge Label for the pull requests that are ready to merge label Feb 9, 2024
@IgnacioBecerra IgnacioBecerra merged commit 8da0be7 into carbon-design-system:release/v2.3.0 Feb 9, 2024
9 of 11 checks passed
@ibmdotcom-bot
Copy link
Contributor

@ibmdotcom-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[carbon-web-components]: is-sortable in <cds-table-header-cell> doesn't work
3 participants