Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CWC cds-code-snippet]: copy button is hidden #11475

Closed
2 tasks done
korgan00 opened this issue Feb 1, 2024 · 1 comment · Fixed by #11492
Closed
2 tasks done

[CWC cds-code-snippet]: copy button is hidden #11475

korgan00 opened this issue Feb 1, 2024 · 1 comment · Fixed by #11492
Assignees
@ariellalgilmore
Labels
bug Something isn't working dev Needs some dev work package: carbon web components severity 2 Affects major functionality, has a workaround

Comments

@korgan00
Copy link
Contributor

korgan00 commented Feb 1, 2024

Description

The cds-code-snippet copy button is hidden by the div with the code. This is only happening in web-components.

React:

Captura de pantalla 2024-02-01 a las 12 42 52

Web-components

Captura de pantalla 2024-02-01 a las 12 42 40 Captura de pantalla 2024-02-01 a las 12 43 18

Component(s) impacted

cds-code-snippet

Browser

Chrome

Carbon for IBM.com version

2.2.0

Severity

Severity 1 = The design is broken in a critical way that blocks users from completing tasks or damages the brand. Affects major functionality, no workaround.

Application/website

Quantum Learning Platform

Package

@carbon/web-components

CodeSandbox example

https://web-components.carbondesignsystem.com/?path=/story/components-code-snippet--multiline

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct
@korgan00 korgan00 added bug Something isn't working dev Needs some dev work labels Feb 1, 2024
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Feb 5, 2024
@kennylam kennylam added the severity 2 Affects major functionality, has a workaround label Feb 5, 2024
@ariellalgilmore ariellalgilmore self-assigned this Feb 5, 2024
@ariellalgilmore ariellalgilmore mentioned this issue Feb 5, 2024
Merged
@ariellalgilmore ariellalgilmore moved this from Backlog to Doing in Carbon for IBM.com Feb 5, 2024
@ariellalgilmore ariellalgilmore moved this from Doing to Review in Carbon for IBM.com Feb 5, 2024
@kodiakhq kodiakhq bot closed this as completed in #11492 Feb 7, 2024
kodiakhq bot pushed a commit that referenced this issue Feb 7, 2024
@ariellalgilmore
fix(code-snippet): multi copy button (#11492)
c65ed61 
### Related Ticket(s)

Closes #11475

### Description

copy button is getting hidden in code-snippet multi. 
### Changelog

**Changed**

- added z-index: 10 to follow react styles

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Feb 7, 2024
@korgan00
Copy link
Contributor Author

korgan00 commented Feb 8, 2024

Thank you!

kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Mar 12, 2024
@ariellalgilmore @kennylam
fix(code-snippet): multi copy button (carbon-design-system#11492)
c15c09b 
### Related Ticket(s)

Closes carbon-design-system#11475

### Description

copy button is getting hidden in code-snippet multi. 
### Changelog

**Changed**

- added z-index: 10 to follow react styles

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this issue Jun 11, 2024
@ariellalgilmore
fix(code-snippet): multi copy button (carbon-design-system#11492)
1e536c8 
### Related Ticket(s)

Closes carbon-design-system#11475

### Description

copy button is getting hidden in code-snippet multi. 
### Changelog

**Changed**

- added z-index: 10 to follow react styles

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariellalgilmore ariellalgilmore

Labels
bug Something isn't working dev Needs some dev work package: carbon web components severity 2 Affects major functionality, has a workaround
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(code-snippet): multi copy button ariellalgilmore/carbon-for-ibm-dotcom
3 participants
@kennylam @korgan00 @ariellalgilmore