Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web-components]: Video component has no play button and thumbnail is not correctly displayed #11399

Closed
2 tasks done
NicoletaBordea opened this issue Jan 12, 2024 · 0 comments · Fixed by #11450
Closed
2 tasks done
Assignees
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package

Comments

@NicoletaBordea
Copy link

Description

Video player component has no play button when loaded and the image is not correctly displayed:
looking like this in v2:
Screenshot 2024-01-12 at 13 20 21
and should be displayed like this:
Screenshot 2024-01-12 at 13 21 40

Component(s) impacted

Video player

Browser

Chrome

Carbon for IBM.com version

v2.1.0-rc.0

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

ibm docs

Package

@carbon/ibmdotcom-web-components

CodeSandbox example

https://carbon-design-system.github.io/carbon-for-ibm-dotcom/next/web-components/?path=/story/components-video-player--default&knob-CTA%20copy:=Learn%20more%20about%20NLP&knob-Content%20item%20type=media&knob-Copy:=true&knob-Heading:=Natural%20language%20understanding&knob-Media%20type:=video

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@NicoletaBordea NicoletaBordea added bug Something isn't working dev Needs some dev work labels Jan 12, 2024
@kennylam kennylam added the package: web components Work necessary for the IBM.com Library web components package label Jan 22, 2024
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Jan 22, 2024
@sangeethababu9223 sangeethababu9223 self-assigned this Jan 25, 2024
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Doing in Carbon for IBM.com Jan 25, 2024
@sangeethababu9223 sangeethababu9223 moved this from Doing to Review in Carbon for IBM.com Jan 25, 2024
@kodiakhq kodiakhq bot closed this as completed in #11450 Jan 31, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 31, 2024
### Related Ticket(s)

Closes #11399

### Description

Video component has no play button and thumbnail is not correctly displayed.

### Changelog

**Changed**

- `padding-block-start` css property for the `c4d-image` component is changed to 0.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@github-project-automation github-project-automation bot moved this from Review to Done in Carbon for IBM.com Jan 31, 2024
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this issue Feb 1, 2024
…tem#11450)

### Related Ticket(s)

Closes carbon-design-system#11399

### Description

Video component has no play button and thumbnail is not correctly displayed.

### Changelog

**Changed**

- `padding-block-start` css property for the `c4d-image` component is changed to 0.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants