Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(stackblitz): fix and standardize masthead examples for v2 #11199

Merged
merged 21 commits into from
Jan 31, 2024
Merged

fix(stackblitz): fix and standardize masthead examples for v2 #11199

merged 21 commits into from
Jan 31, 2024

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented Dec 5, 2023 •
edited
Loading

Related Ticket(s)

Description

Updates the masthead component's CodeSandbox Stackblitz examples with up-to-date demonstrations for v2.

Changelog

Changed

  • Updates masthead Stackblitz examples for v2.

@jkaeser jkaeser added package: web components Work necessary for the IBM.com Library web components package v2 labels Dec 5, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 5, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11199/index.html

Built with commit: 855f370fd4bc05a1937d0a659b4090cbeb94ae64

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 5, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11199/index.html

Built with commit: 855f370fd4bc05a1937d0a659b4090cbeb94ae64

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 5, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11199/index.html

Built with commit: 855f370fd4bc05a1937d0a659b4090cbeb94ae64

@jkaeser jkaeser marked this pull request as ready for review December 12, 2023 15:49
@jkaeser jkaeser requested a review from a team as a code owner December 12, 2023 15:49
@jkaeser jkaeser marked this pull request as draft December 12, 2023 15:50
@jkaeser jkaeser marked this pull request as ready for review December 14, 2023 20:46
@jkaeser jkaeser changed the title fix(codesandbox): fix and standardize masthead examples for v2 rc fix(codesandbox): fix and standardize masthead examples for v2 Dec 14, 2023
@jkaeser jkaeser changed the title fix(codesandbox): fix and standardize masthead examples for v2 fix(stackblitz): fix and standardize masthead examples for v2 Dec 21, 2023
m4olivei
m4olivei suggested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that in the README.mdx, the Stackblitz links for L0 and L1 still have codesandbox in the URL path

image

packages/web-components/examples/stackblitz/components/cloud-masthead/src/index.scss Outdated Show resolved Hide resolved
packages/web-components/examples/stackblitz/components/masthead-l1/src/index.js Outdated Show resolved Hide resolved
@jkaeser
Copy link
Member Author

jkaeser commented Jan 2, 2024 •
edited
Loading

I also noticed that in the README.mdx, the Stackblitz links for L0 and L1 still have codesandbox in the URL path

@m4olivei I'm not sure what's up with that. I see the same for all the other other components in their Storybook READMEs, which indicates it's either a part of the URL the DPO team wants to keep, or it's a problem that needs fixing across the board. Either way, I'd argue it's out of scope for this PR.

@jkaeser jkaeser requested a review from m4olivei January 2, 2024 20:39
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 18, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11199/index.html

Built with commit: 855f370fd4bc05a1937d0a659b4090cbeb94ae64

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 19, 2024
@kodiakhq kodiakhq bot merged commit c3ddeb8 into carbon-design-system:main Jan 31, 2024
12 of 19 checks passed
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this pull request Feb 1, 2024
@jkaeser @m4olivei
fix(stackblitz): fix and standardize masthead examples for v2 (carbon…
5630542 
…-design-system#11199)

### Related Ticket(s)

### Description

Updates the masthead component's ~~CodeSandbox~~ Stackblitz examples with up-to-date demonstrations for v2.

### Changelog

**Changed**

- Updates masthead Stackblitz examples for v2.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@jkaeser
fix(stackblitz): fix and standardize masthead examples for v2 (carbon…
6a870d5 
…-design-system#11199)

### Related Ticket(s)

### Description

Updates the masthead component's ~~CodeSandbox~~ Stackblitz examples with up-to-date demonstrations for v2.

### Changelog

**Changed**

- Updates masthead Stackblitz examples for v2.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4olivei m4olivei m4olivei approved these changes

@kennylam kennylam Awaiting requested review from kennylam kennylam is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
👀 eyes needed package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkaeser @ibmdotcom-bot @m4olivei @kennylam