Skip to content

Commit

Permalink
fix(megamenu-tab): change default value override method (#12088)
Browse files Browse the repository at this point in the history
### Related Ticket(s)

Closes #12087 

### Description

Updates the method by which the megamenu-tab component overrides inherited values.

### Testing

I'm not sure there's a good way to test this change and its impact on projects using react-wrapped components. For now, we should focus on making sure not to introduce regressions into the web components.

### Changelog

**Changed**

- fixes a bug in react-wrapped components
  • Loading branch information
andy-blum authored Nov 19, 2024
1 parent 0db31c4 commit 5eb3f7f
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/web-components/src/components/masthead/megamenu-tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ const { stablePrefix: c4dPrefix } = c4dSettings;
*/
@customElement(`${c4dPrefix}-megamenu-tab`)
class C4DMegaMenuTab extends CDSTab {
/**
* Disable unneeded properties inherited from CDS Content Switcher Item.
*/
closeOnActivation = false;
hideDivider = false;
connectedCallback() {
super.connectedCallback();
this.closeOnActivation = false;
this.hideDivider = false;
}

render() {
const { disabled, selected, value } = this;
Expand Down

0 comments on commit 5eb3f7f

Please sign in to comment.