chore(lint): remove unused vars

carbon-design-system · Nov 22, 2023 · 3b3f5d6 · 3b3f5d6
1 parent f685c17
commit 3b3f5d6
Show file tree

Hide file tree

Showing 12 changed files with 8 additions and 37 deletions.
diff --git a/packages/carbon-web-components/.eslintrc.js b/packages/carbon-web-components/.eslintrc.js
@@ -51,7 +51,7 @@ module.exports = {
       plugins: ['@typescript-eslint'],
       rules: {
         'no-unused-vars': 0,
-        '@typescript-eslint/no-unused-vars': 0,
+        '@typescript-eslint/no-unused-vars': 1,
         'jsdoc/require-param-type': 0,
         'jsdoc/require-returns-type': 0,
         'no-undef': 0,

diff --git a/packages/carbon-web-components/src/components/button/button.ts b/packages/carbon-web-components/src/components/button/button.ts
@@ -90,7 +90,7 @@ class CDSButton extends HostListenerMixin(FocusMixin(LitElement)) {
    */
   @HostListener('focus')
   // @ts-ignore: The decorator refers to this method but TS thinks this method is not referred to
-  private _handleFocus = async (event) => {
+  private _handleFocus = async () => {
     this.openTooltip = true;
   };
 
@@ -100,7 +100,7 @@ class CDSButton extends HostListenerMixin(FocusMixin(LitElement)) {
    */
   @HostListener('focusout')
   // @ts-ignore: The decorator refers to this method but TS thinks this method is not referred to
-  private _handleFocusout = async (event) => {
+  private _handleFocusout = async () => {
     this.openTooltip = false;
   };
 

diff --git a/...ges/carbon-web-components/src/components/data-table/stories/data-table-expansion-story.ts b/...ges/carbon-web-components/src/components/data-table/stories/data-table-expansion-story.ts
@@ -11,10 +11,6 @@ import { html } from 'lit';
 import { boolean, select, text } from '@storybook/addon-knobs';
 import { prefix } from '../../../globals/settings';
 import { TABLE_SIZE } from '../table';
-// @ts-ignore
-import Download16 from '@carbon/web-components/es/icons/download/16';
-// @ts-ignore
-import Settings16 from '@carbon/web-components/es/icons/settings/16';
 import '../index';
 import storyDocs from './data-table-story.mdx';
 

diff --git a/...ges/carbon-web-components/src/components/data-table/stories/data-table-selection-story.ts b/...ges/carbon-web-components/src/components/data-table/stories/data-table-selection-story.ts
@@ -11,10 +11,6 @@ import { html } from 'lit';
 import { boolean, select, text } from '@storybook/addon-knobs';
 import { prefix } from '../../../globals/settings';
 import { TABLE_SIZE } from '../table';
-// @ts-ignore
-import Download16 from '@carbon/web-components/es/icons/download/16';
-// @ts-ignore
-import Settings16 from '@carbon/web-components/es/icons/settings/16';
 import '../index';
 import storyDocs from './data-table-story.mdx';
 

diff --git a/packages/carbon-web-components/src/components/data-table/stories/data-table-sorting-story.ts b/packages/carbon-web-components/src/components/data-table/stories/data-table-sorting-story.ts
@@ -11,8 +11,6 @@ import { html } from 'lit';
 import { boolean, select, text } from '@storybook/addon-knobs';
 import { prefix } from '../../../globals/settings';
 import { TABLE_SIZE } from '../table';
-// @ts-ignore
-import Settings16 from '@carbon/web-components/es/icons/settings/16';
 import '../index';
 import storyDocs from './data-table-story.mdx';
 

diff --git a/packages/carbon-web-components/src/components/data-table/stories/data-table-toolbar-story.ts b/packages/carbon-web-components/src/components/data-table/stories/data-table-toolbar-story.ts
@@ -12,8 +12,6 @@ import { boolean, select, text } from '@storybook/addon-knobs';
 import { prefix } from '../../../globals/settings';
 import { TABLE_SIZE } from '../table';
 // @ts-ignore
-import Download16 from '@carbon/web-components/es/icons/download/16';
-// @ts-ignore
 import Settings16 from '@carbon/web-components/es/icons/settings/16';
 import OverflowMenuVertical16 from '@carbon/icons/lib/overflow-menu--vertical/16';
 import '../index';

diff --git a/packages/carbon-web-components/src/components/data-table/table-skeleton.ts b/packages/carbon-web-components/src/components/data-table/table-skeleton.ts
@@ -139,11 +139,11 @@ class CDSTableSkeleton extends LitElement {
         </thead>
         <tbody>
           ${Array.from(new Array(rowCount)).map(
-            (_) =>
+            () =>
               html`
                 <tr>
                   ${Array.from(new Array(columnCount)).map(
-                    (_) =>
+                    () =>
                       html`
                         <td>
                           <span></span>

diff --git a/packages/carbon-web-components/src/components/floating-menu/floating-menu.ts b/packages/carbon-web-components/src/components/floating-menu/floating-menu.ts
@@ -121,7 +121,7 @@ abstract class CDSFloatingMenu extends HostListenerMixin(
 
   @HostListener('click')
   // @ts-ignore: The decorator refers to this method but TS thinks this method is not referred to
-  private _click = (event: MouseEvent) => {
+  private _click = () => {
     const { parent } = this;
     if (parent) {
       parent.open = false;

diff --git a/packages/carbon-web-components/src/components/slug/slug-story.ts b/packages/carbon-web-components/src/components/slug/slug-story.ts
@@ -9,10 +9,6 @@
 
 import { html } from 'lit';
 import { select } from '@storybook/addon-knobs';
-// Below path will be there when an application installs `carbon-web-components` package.
-// In our dev env, we auto-generate the file and re-map below path to to point to the generated file.
-// @ts-ignore
-import Filter16 from 'carbon-web-components/es/icons/filter/16';
 import View16 from '@carbon/icons/lib/view/16';
 import FolderOpen16 from '@carbon/icons/lib/folder--open/16';
 import Folders16 from '@carbon/icons/lib/folders/16';
@@ -87,7 +83,7 @@ const actions = html`
   <cds-slug-action-button>View Literature</cds-slug-action-button>
 `;
 
-export const Default = (args) => {
+export const Default = () => {
   return html`
     <style>
       ${styles}

diff --git a/packages/carbon-web-components/src/components/toggle-tip/toggletip-story.ts b/packages/carbon-web-components/src/components/toggle-tip/toggletip-story.ts
@@ -9,10 +9,6 @@
 
 import { html } from 'lit';
 import { select } from '@storybook/addon-knobs';
-// Below path will be there when an application installs `carbon-web-components` package.
-// In our dev env, we auto-generate the file and re-map below path to to point to the generated file.
-// @ts-ignore
-import Filter16 from 'carbon-web-components/es/icons/filter/16';
 import textNullable from '../../../.storybook/knob-text-nullable';
 import { ifDefined } from 'lit/directives/if-defined.js';
 import { prefix } from '../../globals/settings';

diff --git a/packages/carbon-web-components/tests/typings/snapshot.d.ts b/packages/carbon-web-components/tests/typings/snapshot.d.ts
@@ -8,7 +8,7 @@
  */
 
 declare namespace jasmine {
-  interface Matchers<T> {
+  interface Matchers {
     toMatchSnapshot(options?: { mode: string }): boolean;
   }
 }
diff --git a/packages/web-components/src/components/link-list/__tests__/link-list.test.ts b/packages/web-components/src/components/link-list/__tests__/link-list.test.ts
@@ -12,7 +12,6 @@ import {
   Default,
   Horizontal,
   Vertical,
-  EndOfSection,
 } from '../__stories__/link-list.stories';
 
 describe('c4d-link-list', function () {
@@ -62,14 +61,6 @@ describe('c4d-link-list', function () {
     });
   });
 
-  it('Renders End of section', async function () {
-    render(EndOfSection({ parameters: {} }), document.body);
-    await Promise.resolve();
-    expect(document.body.querySelector('c4d-link-list')).toMatchSnapshot({
-      mode: 'shadow',
-    });
-  });
-
   afterEach(async function () {
     await render(undefined!, document.body);
   });