Skip to content

Commit

Permalink
chore(deps): remove duplicate build storybook from percy command (#11433
Browse files Browse the repository at this point in the history
)

### Description

The `build-storybook` is running twice since it is included in the `visual-snapshot` command. This removes the extra build command.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- remove `build-storybook` from `visual-snapshot`

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
  • Loading branch information
kennylam authored Jan 22, 2024
1 parent 954ecf4 commit 1a251c0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/percy-update-base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
KALTURA_UICONF_ID: ${{ secrets.KALTURA_UICONF_ID }}
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN_WEBCOMPONENTS }}
- name: Run percy storybook
run: yarn visual-snapshot
run: yarn build-storybook && visual-snapshot
working-directory: packages/web-components
carbon-web-components:
if: github.repository == 'carbon-design-system/carbon-for-ibm-dotcom'
Expand Down Expand Up @@ -67,5 +67,5 @@ jobs:
KALTURA_UICONF_ID: ${{ secrets.KALTURA_UICONF_ID }}
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN_CARBONWEBCOMPONENTS }}
- name: Run percy storybook
run: yarn visual-snapshot
run: yarn build-storybook && visual-snapshot
working-directory: packages/carbon-web-components
2 changes: 1 addition & 1 deletion packages/carbon-web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:unit": "gulp test:unit",
"test:unit:updateSnapshot": "gulp test:unit --update-snapshot",
"typecheck": "tsc --noEmit -p tsconfig.json",
"visual-snapshot": "yarn build-storybook && percy storybook:start ./storybook-static",
"visual-snapshot": "yarn percy storybook:start ./storybook-static",
"wca": "web-component-analyzer analyze src --outFile custom-elements.json"
},
"files": [
Expand Down
2 changes: 1 addition & 1 deletion packages/web-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"test:unit:updateSnapshot": "gulp test:unit --update-snapshot",
"typecheck": "tsc --noEmit -p tsconfig.json",
"upgrade-carbon": "yarn upgrade-interactive @carbon/web-components @carbon/icon-helpers @carbon/icons --latest --exact",
"visual-snapshot": "yarn build-storybook && percy storybook:start ./storybook-static",
"visual-snapshot": "yarn percy storybook:start ./storybook-static",
"wca": "web-component-analyzer analyze src --outFile custom-elements.json"
},
"dependencies": {
Expand Down

0 comments on commit 1a251c0

Please sign in to comment.