Skip to content

Commit

Permalink
Merge branch 'release/v1.55.0' of https://github.com/carbon-design-sy…
Browse files Browse the repository at this point in the history
…stem/carbon-for-ibm-dotcom into release/v1.55.0
  • Loading branch information
IgnacioBecerra committed Feb 5, 2024
2 parents 32cffc8 + 8d8f798 commit 0c52f53
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ class BXCheckbox extends FocusMixin(FormMixin(LitElement)) {
type="checkbox"
part="input"
class="${`${prefix}--checkbox`}"
aria-checked="${indeterminate ? 'mixed' : String(Boolean(checked))}"
.checked="${checked}"
?disabled="${disabled}"
.indeterminate="${indeterminate}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,15 @@ class BXPagesSelect extends FocusMixin(LitElement) {
// https://github.com/Polymer/lit-html/issues/1052
return html`
<div class="${prefix}--select__page-number">
<label for="select" class="${prefix}--label ${prefix}--visually-hidden">
<label
for="select-page"
class="${prefix}--label ${prefix}--visually-hidden">
${formatLabelText({ count: total })}
</label>
<select
class="${prefix}--select-input"
.value="${value}"
id="select-page"
@change="${handleChange}">
${Array.from(new Array(total)).map(
(_item, index) =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ class StickyHeader {
if (localeModal && localeModal.hasAttribute('open')) return;

const newY = window.scrollY;
this._lastScrollPosition = newY;
this._lastScrollPosition = Math.max(0, newY);

/**
* maxScrollaway is a calculated value matching the height of all components
Expand Down

0 comments on commit 0c52f53

Please sign in to comment.