Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues #3910

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix minor issues #3910

merged 4 commits into from
Jan 7, 2025

Conversation

herleraja
Copy link
Collaborator

@herleraja herleraja commented Dec 30, 2024

Closes #

Summary

  • fixing number of image card issues

Change List (commits, features, bugs, etc)

  • items_here

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit ed92dd5
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/677d1e96ed25f1000740f675
😎 Deploy Preview https://deploy-preview-3910--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@herleraja herleraja force-pushed the fix-minor-issues branch 2 times, most recently from baf5271 to 54bca63 Compare December 30, 2024 17:15
@herleraja herleraja self-assigned this Dec 30, 2024
@herleraja herleraja force-pushed the fix-minor-issues branch 3 times, most recently from c650655 to a3134dd Compare January 7, 2025 12:26
@herleraja herleraja marked this pull request as ready for review January 7, 2025 12:36
@herleraja herleraja merged commit c9fbb14 into next Jan 7, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant