Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tooltip to the tablecard column and value card label #3871

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

herleraja
Copy link
Collaborator

@herleraja herleraja commented Jun 24, 2024

Closes MASMON-1704

Summary

Dashboard Editor: https://deploy-preview-3871--carbon-addons-iot-react.netlify.app/?path=/story/2-watson-iot-experimental-%E2%98%A2%EF%B8%8F-dashboardeditor--with-initial-value
Click the edit data item button to view the modal
image

Change List (commits, features, bugs, etc)

  • feat: add tooltip to the tablecard column and value card label
  • chore: adding amrith as a code owner to get PR reviews

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 41a1d6a
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/66794c309ac5900008fbb4aa
😎 Deploy Preview https://deploy-preview-3871--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


{(type === CARD_TYPES.VALUE || type === CARD_TYPES.IMAGE) && (
<div className={`${baseClassName}--input-group`}>
{hasTooltip && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we keep the previous validation, by just deleting that, we can impact others that use this component, and maybe add deprecation if we are removing the type prop

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have deleted here. But in the parent component ,I kept it same. So functionality wise there is no change.
image

Copy link
Collaborator

@blechner blechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to add support for tooltip seem ok, however, I think that we should always keep backward compatibility since we are not generating a major version.

@blechner blechner self-requested a review June 24, 2024 12:56
Copy link
Collaborator

@blechner blechner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herleraja herleraja merged commit ff7a69c into next Jun 24, 2024
27 checks passed
@herleraja herleraja deleted the feat-add-tooltip-field branch June 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants