Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump carbon packages #3858

Merged
merged 31 commits into from
Jul 16, 2024
Merged

chore: bump carbon packages #3858

merged 31 commits into from
Jul 16, 2024

Conversation

herleraja
Copy link
Collaborator

@herleraja herleraja commented Apr 19, 2024

image

Summary

Change List (commits, features, bugs, etc)

  • chore: bump carbon packages

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 583d870
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/669636bd0e9a090008733a97
😎 Deploy Preview https://deploy-preview-3858--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@herleraja herleraja closed this Jun 5, 2024
@herleraja herleraja reopened this Jun 5, 2024
@herleraja herleraja marked this pull request as ready for review July 16, 2024 08:38
@herleraja herleraja requested review from a team, davidicus, jessieyan and sls-ca as code owners July 16, 2024 08:38
@herleraja herleraja requested review from cgirani and sls-ca and removed request for davidicus, jessieyan and sls-ca July 16, 2024 08:39
Copy link
Collaborator

@cgirani cgirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sls-ca sls-ca merged commit a961ace into next Jul 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants