Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetimepickerv2withtimespinner): added null undefined check #3845

Conversation

abpaul1993
Copy link
Collaborator

@abpaul1993 abpaul1993 commented Feb 27, 2024

Closes #
GRAPHITE-73143
Summary
In DateTimePickerV2WithTimeSpinner component there was an issue !singleDateValue.startDate in this logic because if the singleDateValue is null or undefined it was giving exception that cannot read properties of null.

  • summary_here

Change List (commits, features, bugs, etc)

  • items_here

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

Copy link

netlify bot commented Feb 27, 2024

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit b9fc0f2
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/65ddccaaf7e69300081f9bcd
😎 Deploy Preview https://deploy-preview-3845--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hectordavis hectordavis merged commit 038c828 into next Feb 27, 2024
29 checks passed
@hectordavis hectordavis deleted the GRAPHITE-73143-DateTimePickerV2WithTimeSpinner-null-undefined-check branch February 27, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants