Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3838
Summary
Enahnces table drag and drop feature to drop table rows outside the table over breadcrumb nodes.
Change List (commits, features, bugs, etc)
Majority of the work is done in the
useTableDnd.jsx
. ProphasBreadcrumbDrop
is used to enable this feature in addition tohasDragAndDrop
of table. When drag is started upon setting up of drag and drop throughuseEffect
hook, mouse events likemouseEnter
andmouseLeave
are attached to all the breadcrumb nodes in the dom. Upon drop or drag cancel all these event listeners are removed.Acceptance Test (how to verify the PR)
hasBradcrumbDrop
checked in knobs. Will allow drop over breadcrumb nodes. For nodes inside the ellipsis, user need to first open that by clicking then need to perfrom drag and drop over those nodes.Regression Test (how to make sure this PR doesn't break old functionality)
Things to look for during review
iot
orbx
class prefix is using the prefix variabledata-testid
attribute. New test ids should have test written to ensure they are not changed or removed.