Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datetimepickerv2): datetimepickerV2 hide back button props #3835

Conversation

abpaul1993
Copy link
Collaborator

@abpaul1993 abpaul1993 commented Jan 4, 2024

Closes #
https://jsw.ibm.com/browse/GRAPHITE-62796
Summary
When using only the absolute date range selector, a back button appears in the footer to return to the default preset list. However, according to the design, we should not display a back button. Instead, I have replaced it with a cancel button, which will reset the date range to the previously selected one and close the flyout.

  • summary_here

Change List (commits, features, bugs, etc)
DateTimePickerV2(useNewTimeSpinner)

  • items_here

Acceptance Test (how to verify the PR)

  • tests here

Regression Test (how to make sure this PR doesn't break old functionality)

  • tests here

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@abpaul1993 abpaul1993 requested review from hectordavis and cgirani and removed request for jessieyan January 4, 2024 08:04
Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit f81d7d7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6596656d23e0c900089389ff
😎 Deploy Preview https://deploy-preview-3835--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sls-ca sls-ca merged commit 3e9a2d3 into next Jan 4, 2024
29 checks passed
@sls-ca sls-ca deleted the feat-GRAPHITE-62796-Date-range-selector-Absolute-hide-back-button branch January 4, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants