Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codeeditor): New Code editor component #3830

Merged
merged 15 commits into from
Oct 19, 2023
Merged

Conversation

cgirani
Copy link
Collaborator

@cgirani cgirani commented Oct 16, 2023

Summary

New component CodeEditor

Change List (commits, features, bugs, etc)

  • Update version of @monaco-editor/react package
  • New component CodeEditor

Acceptance Test (how to verify the PR)

  • Test component and it's knobs

Regression Test (how to make sure this PR doesn't break old functionality)

  • Make sure CardCodeEditor keep working after package upgrade

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@cgirani cgirani marked this pull request as ready for review October 16, 2023 17:46
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 29fd7e8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/6530228b6a9eb800084255bc
😎 Deploy Preview https://deploy-preview-3830--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@herleraja
Copy link
Collaborator

can you check if this effect dashboard code editor
image
example : https://deploy-preview-3830--carbon-addons-iot-react.netlify.app/?path=/story/2-watson-iot-experimental-%E2%98%A2%EF%B8%8F-dashboardeditor--with-editable-title

  • add a card
  • click on open json editor
    image
  • then click on save. Ideally, it should save.

@herleraja herleraja self-assigned this Oct 18, 2023
Copy link
Collaborator

@herleraja herleraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading monaco-editor. However, the dashboard editor is not working as expected.

@herleraja herleraja removed their assignment Oct 18, 2023
@cgirani cgirani requested a review from herleraja October 18, 2023 16:28
@cgirani cgirani requested a review from herleraja October 18, 2023 18:23
Copy link
Collaborator

@herleraja herleraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants