Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove engines #3827

Merged
merged 9 commits into from
Oct 13, 2023
Merged

fix: Remove engines #3827

merged 9 commits into from
Oct 13, 2023

Conversation

cgirani
Copy link
Collaborator

@cgirani cgirani commented Sep 22, 2023

Summary

Remove the defined engines

Things to look for during review

  • Make sure all references to iot or bx class prefix is using the prefix variable
  • (React) All major areas have a data-testid attribute. New test ids should have test written to ensure they are not changed or removed.
  • UI should be checked in RTL mode to ensure the proper handling of layout and text.
  • All strings should be translatable.
  • The code should pass a11y scans (The storybook a11y knob should show no violations). New components should have a11y test written.
  • Unit test should be written and should have a coverage of 90% or higher in all areas.
  • All components should be passing visual regression test. For new styles or components either a visual regression test should be written for all permutations or the base image updated.
  • Changes or new components should either write new or update existing documentation.
  • PR should link and close out an existing issue

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for carbon-addons-iot-react ready!

Name Link
🔨 Latest commit 6e85b05
🔍 Latest deploy log https://app.netlify.com/sites/carbon-addons-iot-react/deploys/65297d427a7b440008216ffc
😎 Deploy Preview https://deploy-preview-3827--carbon-addons-iot-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cgirani cgirani marked this pull request as ready for review October 13, 2023 17:59
@cgirani cgirani requested review from a team, davidicus and jessieyan as code owners October 13, 2023 17:59
@cgirani cgirani changed the title Remove engines chore: Remove engines Oct 13, 2023
@cgirani cgirani changed the title chore: Remove engines fix: Remove engines Oct 13, 2023
@cgirani cgirani merged commit 7c2f4f9 into next Oct 13, 2023
27 checks passed
@cgirani cgirani deleted the remove-engines branch October 13, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants