Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Responsive design at the largest font size #1337

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

hatsu38
Copy link
Contributor

@hatsu38 hatsu38 commented Feb 10, 2022

The code should not overflow on mobile when using the largest font size.

Detail: #1287 (comment)

Setting Parameters

  • Editor -> Setting Max Size
  • Window -> Setting Max Padding Horizontal Size

Before

スクリーンショット 2022-02-10 19 07 26

After

スクリーンショット 2022-02-10 19 06 49

Closes #1287

  • Integration tests (if applicable)

The code should not overflow on mobile when using the largest font size.
@vercel
Copy link

vercel bot commented Feb 10, 2022

@hatsu38 is attempting to deploy a commit to the Carbon Team on Vercel.

A member of the Team first needs to authorize it.

@hatsu38 hatsu38 marked this pull request as ready for review February 10, 2022 10:29
@mfix22 mfix22 merged commit 5153350 into carbon-app:main Feb 19, 2022
@mfix22
Copy link
Contributor

mfix22 commented Feb 19, 2022

Thanks again @hatsu38 🙏

@hatsu38 hatsu38 deleted the feature/max-fontsize-for-mobile branch February 20, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web app is unusable on mobile
2 participants