Skip to content

Commit

Permalink
Add additional ARG version line in Dockerfile (#423)
Browse files Browse the repository at this point in the history
<!--  Thanks for sending a pull request!  Here are some tips for you:

1. Run unit tests and ensure that they are passing
2. If your change introduces any API changes, make sure to update the
e2e tests
3. Make sure documentation is updated for your PR!

-->

**What this PR does / why we need it**:
<!-- Explain here the context and why you're making the change. What is
the problem you're trying to solve. --->

In #404, Merlin SDK Dockerfile misses ARG version.

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required. Enter your extended release note in
the block below.
If the PR requires additional action from users switching to the new
release, include the string "action required".

For more information about release notes, see kubernetes' guide here:
http://git.k8s.io/community/contributors/guide/release-notes.md
-->

```release-note
NONE
```

**Checklist**

- [ ] Added unit test, integration, and/or e2e tests
- [x] Tested locally
- [ ] Updated documentation
- [ ] Update Swagger spec if the PR introduce API changes
- [ ] Regenerated Golang and Python client if the PR introduce API
changes
  • Loading branch information
ariefrahmansyah authored Jul 6, 2023
1 parent 861a18f commit 84c4383
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions python/sdk/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,7 @@ RUN apt-get update && apt-get install build-essential curl vim wget -y

COPY . .${WORKDIR}

ARG VERSION

RUN pip install merlin-sdk==${VERSION}
RUN pip install merlin-sdk[test]==${VERSION}

0 comments on commit 84c4383

Please sign in to comment.