Remove commented code

caraml-dev · Sep 9, 2024 · 350783e · 350783e
1 parent 0eb1b13
commit 350783e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/...l-store-serving/src/main/java/dev/caraml/serving/store/bigtable/HBaseOnlineRetriever.java b/...l-store-serving/src/main/java/dev/caraml/serving/store/bigtable/HBaseOnlineRetriever.java
@@ -57,25 +57,11 @@ public List<List<Feature>> convertRowToFeature(
                 return featureReferences.stream()
                     .map(ServingServiceProto.FeatureReference::getFeatureTable)
                     .distinct()
-                    .map(
-                        cf -> {
-                          List<Cell> rowCells = row.getColumnCells(cf.getBytes(), null);
-                          System.out.println("Column Family: " + cf);
-                          System.out.println("Row Cells: " + rowCells);
-                          return rowCells;
-                        })
-                    //                    .map(cf -> row.getColumnCells(cf.getBytes(), null))
+                    .map(cf -> row.getColumnCells(cf.getBytes(), null))
                     .filter(ls -> !ls.isEmpty())
                     .flatMap(
                         rowCells -> {
                           Cell rowCell = rowCells.get(0); // Latest cell
-                          //                          String family =
-                          // Bytes.toString(rowCell.getFamilyArray());
-                          //                          System.out.println("rowCell: " +
-                          // rowCell.toString());
-                          //                          ByteString value =
-                          // ByteString.copyFrom(rowCell.getValueArray());
-                          //                          System.out.println("value: " + value);
                           ByteBuffer valueBuffer =
                               ByteBuffer.wrap(rowCell.getValueArray())
                                   .position(rowCell.getValueOffset())

diff --git a/...ml-store-serving/src/main/java/dev/caraml/serving/store/bigtable/HBaseSchemaRegistry.java b/...ml-store-serving/src/main/java/dev/caraml/serving/store/bigtable/HBaseSchemaRegistry.java
@@ -95,6 +95,7 @@ private GenericDatumReader<GenericRecord> loadReader(SchemaReference reference)
 
       Cell last = result.getColumnLatestCell(COLUMN_FAMILY.getBytes(), QUALIFIER.getBytes());
       if (last == null) {
+        // NOTE: this should never happen
         throw new RuntimeException("Schema not found");
       }
       ByteBuffer schemaBuffer =