Skip to content

Commit

Permalink
create_perf_json: Don't drop PCU umasks
Browse files Browse the repository at this point in the history
The UMask was dropped for consistency with:
https://github.com/intel/event-converter-for-linux-perf/blob/master/uncore_csv_json.py#L67
However, it leads to all events having the same encoding. Don't drop
the umask which makes them consistent with other libraries like
libpfm4:
https://sourceforge.net/p/perfmon2/libpfm4/ci/master/tree/lib/events/intel_skx_unc_pcu_events.h#l30

A long standing todo () convert to right filter for occupancy
  • Loading branch information
captain5050 committed Feb 26, 2024
1 parent 16f82b2 commit 661a229
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions scripts/create_perf_json.py
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,6 @@ def get(key: str) -> str:
self.unit = unit_fixups[self.unit]
elif self.unit == "NCU" and self.event_name == "UNC_CLOCK.SOCKET":
self.unit = "CLOCK"
elif self.unit == "PCU" and self.umask:
# TODO: convert to right filter for occupancy
self.umask = None
if jd.get('CounterType') == "FREERUN":
self.unit = f"{self.unit.lower()}_free_running"
m = re.search(r'_MC(\d+)_', self.event_name)
Expand Down

0 comments on commit 661a229

Please sign in to comment.