TEST #986
Closed
TEST #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt `num_quantiles` option to `HistogramAndQuantilesOptions` (capitalone#956) * Implemented options for `num_quantiles` feature in `NumericStatsMixin` * Implemented options for `num_quantiles.py`. * Added tests for `num_quantiles`. * Fixed tests for num_quantiles option in column profiles. * Added tests for num_quantiles option. * Update dataprofiler/tests/profilers/profiler_options/test_num_quantiles_option.py Co-authored-by: Taylor Turner <[email protected]> * Minor edits to tests * Empty commit * Precommits * Minor change to Makefile. * Got rid of print statements. * "empty commit" * Added deprecation for `HistogramOption`. * Cleaner deprecation: removed `HistogramOption` class. * json_decoder, test_h_a_q changes. * Fixed string bug for testing in test_histogram_and_quantiles * Explicitfied deprecation warning, validated profile conversion from histogramoption to histogramandquantilesoption in decoding phase. * Minor deprecation warning wording change. * Update dataprofiler/tests/profilers/profiler_options/test_histogram_and_quantiles_option.py Co-authored-by: Taylor Turner <[email protected]> * Changed deprecation warning. * Changed quantiles option to initialize to None. * Minor change * Minor change again D: * Minor change again again D: sadness --------- Co-authored-by: Taylor Turner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.