Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented options for
num_quantiles
feature inNumericStatsMixin
#896Implemented options for
num_quantiles
feature inNumericStatsMixin
#896Changes from 10 commits
4ec2bd6
0023ed5
7d9d995
661a8d0
4d2b6ad
47903d2
4045c58
ea603d2
1c44351
de8104c
26554ae
382f11c
3a19c24
bc5f195
48cbdf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we call this
QuantilesOption
instead? That way it is extensible to more than just the number of quantiles.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree -- more extensible for future development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this should be in
NumericalOptions
? We already haveself.histogram_and_quantiles = HistogramOption()
.Should we rename
HistogramOption
and insert it in that class?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@clee1152 @taylorfturner , thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense. Does this mean we will not go with your previous suggestion of renaming
NumQuantilesOption
toQuantileOptions
and instead just insert it intoHistogramOption
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair Q. @taylorfturner may have more thoughts, but if we are keeping
histogram_and_quantiles
Then we should at least rename
HistogramOption
->HistogramAndQuantilesOption
We could just move over the
num_quantiles
settingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me! Will see what @taylorfturner thinks, then implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @clee1152 and I just talked about this -- I'm game for
self. histogram_and_quantiles = HistogramAndQuantilesOption()
whereself.num_quantiles
is set inclass HistogramAndQuantilesOption()
@JGSweets