Polars feature updates #1119
Merged
Polars feature updates #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-merge was automatically disabled
March 22, 2024 16:43
Head branch was pushed to by a user without write access
Merged
taylorfturner
force-pushed
the
feature/polars
branch
from
6e2c2fa
to
c176d53
Compare
abajpai15
force-pushed
the
polars_feature_rebase
branch
2 times, most recently
from
8fb2da9
to
fdf3171
Compare
Comment on lines
259
to
+260
| len_df = len(df_series) | ||
|
|
||
| is_row_datetime = pd.Series(np.full((len(df_series)), False)) | ||
| is_row_datetime = pd.Series(np.full((len_df), False)) |
Comment on lines
712
to
724
| if type(data) is pl.DataFrame: | ||
| words = ( | ||
| [ | ||
| w.strip(string.punctuation) | ||
| for w in row.str.to_lowercase().str.split(by=" ") | ||
| ] | ||
| for row in data | ||
| ) | ||
| else: | ||
| words = ( | ||
| [w.strip(string.punctuation) for w in row.lower().split()] | ||
| for row in data | ||
| ) |
There was a problem hiding this comment.
pre-commit made it like this?
Comment on lines
726
to
734
| if type(data) is pl.DataFrame: | ||
| words = ( | ||
| [w.strip(string.punctuation) for w in row.str.split(by=" ")] | ||
| for row in data | ||
| ) | ||
| else: | ||
| words = ( | ||
| [w.strip(string.punctuation) for w in row.split()] for row in data | ||
| ) |
There was a problem hiding this comment.
90% of this is similar ... could make this more modular. follow-up PR maybe or if you can crank it out quick can do this
micdavis
previously approved these changes
Apr 5, 2024
taylorfturner
suggested changes
Apr 8, 2024
auto-merge was automatically disabled
April 10, 2024 21:00
Head branch was pushed to by a user without write access
abajpai15
force-pushed
the
polars_feature_rebase
branch
from
6a21fde
to
7e342dd
Compare
taylorfturner
force-pushed
the
feature/polars
branch
from
da23777
to
c176d53
Compare
abajpai15
force-pushed
the
polars_feature_rebase
branch
from
7e342dd
to
0904ba5
Compare
taylorfturner
force-pushed
the
feature/polars
branch
from
c176d53
to
b1f656e
Compare
abajpai15
force-pushed
the
polars_feature_rebase
branch
from
0904ba5
to
8884488
Compare
abajpai15
force-pushed
the
polars_feature_rebase
branch
from
8884488
to
b3633eb
Compare
taylorfturner
approved these changes
Apr 22, 2024
ksneab7
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added polars to datetime_column_profile and unstructured_labeler