Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Outdated> Float column fix for categorical data during precession calculation #1096

Closed
wants to merge 1 commit into from
Closed

<Outdated> Float column fix for categorical data during precession calculation #1096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dataprofiler/profilers/float_column_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,10 @@ def _get_float_precision(

# length of sampled cells after all punctuation removed
len_per_float = (
df_series_clean.sample(sample_size).replace(to_replace=r, value="").map(len)
df_series_clean.sample(sample_size)
.astype(object)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not having this causing a particular issue? It's not clear to me right now why the addition? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @taylorfturner - thank you for the comments. Signed SLA / will fork off dev in the future.

I'm planning to close this PR. I had originally intended this to be a fix for this issue. However, I believe this PR solved the underlying issue.

.replace(to_replace=r, value="")
.map(len)
).astype(float)

# Determine statistics precision
Expand Down