-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
always close pool connections to avoid zlib warnings #457
base: master
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger |
previously, we only closed connections when there are no errors. when we hit errors while executing, we saw misleading zlib errors where instead it was just the ssh command failing. so lets always close connections to avoid those errors.
1c375be
to
96733fa
Compare
@mattbrictson this one would be nice too, unless there was a reason for the old code |
@grosser it's incredibly impolite to ping a contributor by name. Matt is taking some much needed personal time away from the project and @will-in-wi and I are holding down the fort. |
|
@grosser those are features not bugs. And "sitting here without a reply for 2 months" is a side effect of this being a project people work on in their free time. Back off and stop being so abrasive in your online communications please, we owe you nothing, and you owe us nothing, save perhaps a little courtesy. |
After how many months is ok to ask for a review ? |
doubt I can convince you, so I'm done here 👋 |
previously, we only closed connections when there are no errors.
when we hit errors while executing, we saw misleading zlib errors where instead it was just the ssh command failing.
so lets always close connections to avoid those errors.
Fix for #343.
@mattbrictson