Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always close pool connections to avoid zlib warnings #457

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eatwithforks
Copy link

previously, we only closed connections when there are no errors.
when we hit errors while executing, we saw misleading zlib errors where instead it was just the ssh command failing.
so lets always close connections to avoid those errors.

Fix for #343.
@mattbrictson

@capistrano-bot
Copy link

capistrano-bot commented Mar 4, 2019

1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by 🚫 Danger

previously, we only closed connections when there are no errors.
when we hit errors while executing, we saw misleading zlib errors where instead it was just the ssh command failing.
so lets always close connections to avoid those errors.
@grosser
Copy link
Contributor

grosser commented Mar 8, 2019

@mattbrictson this one would be nice too, unless there was a reason for the old code

@grosser
Copy link
Contributor

grosser commented May 9, 2019

@mattbrictson 🛎

@leehambley
Copy link
Member

@grosser it's incredibly impolite to ping a contributor by name. Matt is taking some much needed personal time away from the project and @will-in-wi and I are holding down the fort.

@grosser
Copy link
Contributor

grosser commented May 9, 2019

  • idk who else to ping
  • there is no "ping contributors"
  • this PR is sitting here without a reply for 2 months

@leehambley
Copy link
Member

@grosser those are features not bugs. And "sitting here without a reply for 2 months" is a side effect of this being a project people work on in their free time.

Back off and stop being so abrasive in your online communications please, we owe you nothing, and you owe us nothing, save perhaps a little courtesy.

@grosser
Copy link
Contributor

grosser commented May 9, 2019

After how many months is ok to ask for a review ?
You call me "incredibly impolite" for mentioning people by name, when I did that a thousand times already and have that done to me 10x more, and nobody before has complained about this, and I'm the one being "abrasive" ?

@grosser
Copy link
Contributor

grosser commented May 9, 2019

doubt I can convince you, so I'm done here 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants