support commands/users/groups/directories with spaces or other shell characters #451
+45
−22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should execute "sh -c touch\ 1 &&\ echo\ 1" and not
sh -c touch 1
andecho 1
... same issue for directories/users/groups
... also making user and group use the same form of escaping
... I'm pretty sure
nohup
should also dosh -c
to avoid funky issues/fyi @eatwithforks @adammw @jonmoter this is why we saw crazy issues :D
... cap-devs, please let me know if this looks correct, or if I understood something wrong