fix equality check to be strict equals for number null

caperaven · Feb 22, 2023 · 670f533 · 670f533
1 parent c98d3dd
commit 670f533
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 2 deletions.
diff --git a/src/binding/providers/bind-provider.js b/src/binding/providers/bind-provider.js
@@ -46,7 +46,7 @@ export class BindProvider extends OneWayProvider {
     }
 
     _number(value) {
-        if (value == null || value == "") return null;
+        if (value == null || value === "") return null;
         return Number(value);
     }
 

diff --git a/src/store/binding-data.js b/src/store/binding-data.js
@@ -284,7 +284,7 @@ export class BindingData {
             value = Boolean(value);
         }
         else if (dataType === "number" || (dataType == null && typeof value !== "object" && (isNaN(value) == false && value != ""))) {
-            value = value == null || value == "" ? null : Number(value);
+            value = value == null || value === "" ? null : Number(value);
         }
 
         if (obj.type == "data") {

diff --git a/tests/unit/providers/bind-provider.test.js b/tests/unit/providers/bind-provider.test.js
@@ -39,4 +39,33 @@ describe("bind-provider", async () => {
             assertEquals(crsbinding.data.getProperty(id, "value"), null);
         }
     });
+
+    it("should allow 0 as input", async () => {
+        // Arrange
+        const id = crsbinding.data.addObject("value", {value: null});
+
+        const input = document.createElement("input");
+        input.type = "number";
+        instance = new module.BindProvider(input, id, "value", "value");
+
+        const addEventListener = input.addEventListener;
+        input.addEventListener = (event, callback) => {
+
+            addEventListener(event, callback);
+
+            // Act
+            input.value = "123";
+            input.performEvent("change", input);
+
+            // Assert
+            assertEquals(crsbinding.data.getProperty(id, "value"), 123);
+
+            // Act
+            input.value = "0";
+            input.performEvent("change", input);
+
+            // Assert
+            assertEquals(crsbinding.data.getProperty(id, "value"), 0);
+        }
+    });
 });