Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifests #68

Merged
merged 16 commits into from
May 3, 2022
Merged

Update manifests #68

merged 16 commits into from
May 3, 2022

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Apr 21, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix manifests to make them runnable

Related issue(s)

@mszostok mszostok added bug Something isn't working area/hub-manifests Relates to Hub manifests labels Apr 25, 2022
@mszostok mszostok mentioned this pull request Apr 27, 2022
Closed
@mszostok mszostok marked this pull request as ready for review April 27, 2022 11:08
@mkuziemko mkuziemko self-assigned this Apr 29, 2022
mkuziemko
mkuziemko approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@mkuziemko mkuziemko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, all manifest up to date. 🚀

I went through the details in the issue and LGTM 👍

manifests/type/containerization/kubernetes/kubeconfig.yaml Show resolved Hide resolved
@mszostok mszostok merged commit 9b19eee into capactio:main May 3, 2022
@mszostok mszostok deleted the update-manifests branch May 3, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuziemko mkuziemko mkuziemko approved these changes

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

@pkosiec pkosiec Awaiting requested review from pkosiec pkosiec is a code owner

Assignees

@mkuziemko mkuziemko

Labels
area/hub-manifests Relates to Hub manifests bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @mkuziemko