Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow-down the download TypeInstance details #707

Merged
merged 3 commits into from
May 3, 2022
Merged

Narrow-down the download TypeInstance details #707

merged 3 commits into from
May 3, 2022

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Apr 21, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Narrow-down the download TypeInstance details. Currently, we download all details about TypeInstance together with all relations. This sometimes causes timeouts in download step. Important is that we don't need those details.
  • Change goTemplate to string in Terraform runner
  • Add required delay for value fetcher

Related issue(s)

@mszostok mszostok added enhancement New feature or request area/engine Relates to Engine labels Apr 21, 2022
mkuziemko
mkuziemko approved these changes Apr 21, 2022
View reviewed changes
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mszostok mszostok mentioned this pull request Apr 27, 2022
Closed
mkuziemko
mkuziemko approved these changes Apr 29, 2022
View reviewed changes
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, LGTM, although the title of the PR could be more accurate :)

@mszostok mszostok merged commit 68c6938 into capactio:main May 3, 2022
@mszostok mszostok deleted the fixes branch May 3, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuziemko mkuziemko mkuziemko approved these changes

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

@pkosiec pkosiec Awaiting requested review from pkosiec pkosiec is a code owner

Assignees
No one assigned
Labels
area/engine Relates to Engine enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change output.goTemplate in Terraform-based Implementations to be of type string
2 participants
@mszostok @mkuziemko