Add a hybrid example related to threads #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Apr 9, 2024
| for (size_t i = 0; i < pow(10, 6); ++i) | ||
| { | ||
| }; | ||
| curr_t_info->ddc_out = read_ddc(); |
There was a problem hiding this comment.
Can we add an assert(curr_t_info->ddc_out == curr_t_info->addr_in) or similar here?
There was a problem hiding this comment.
Done in 66126d7. Also added a check to ensure the DDC is changed.
|
Please squash. |
|
Squashed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I've made a bit of an ugly fix in 42f7b6c, but I think a proper fix would involve a bit too much infrastructure changing (at least I can't think of any other more straightforward one to only add the libraries we need to the new test). |
|
I think this is perfectly fine for this repo. Please squash. |
|
Squashed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Is it fine to force-push to get the changes from #95 ? |
|
Please force push a rebase. |
Check whether we can set DDCs for spawned threads individually, and independent from the main program thread.
|
Rebased in e962618 (also fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether we can set DDCs for spawned threads individually, and independent from the main program thread.