1 compartment to N mappings #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Dec 16, 2024
ltratt
reviewed
Dec 16, 2024
ltratt
reviewed
Dec 16, 2024
| @@ -55,7 +57,7 @@ intercept_wrapper(); | |||
| void | |||
| setup_intercepts(); | |||
|
|
|||
| size_t | |||
| my_call_comp(size_t, char *, void *); | |||
| // size_t | |||
There was a problem hiding this comment.
Same as the comment for intercept.c. I can also add a TODO here, if it's worth it.
There was a problem hiding this comment.
A TODO would be good, thanks.
ltratt
reviewed
Dec 16, 2024
ltratt
reviewed
Dec 16, 2024
ltratt
reviewed
Dec 16, 2024
ltratt
reviewed
Dec 16, 2024
ltratt
reviewed
Dec 16, 2024
|
Only one comment left! |
|
Please squash. |
|
Squashed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Seems there's further divergence between my local |
|
Please squash. |
Move from a design of "one compartment has one mapping" to "one compartment can be mapped multiple times". This involves "staging" a compartment, with temporary internal relative relocations, after which the staging can be lifted to a "mapping", which has correct relocations and can be executed. This greatly reduces the overhead of creating the same compartment multiple times. * Remove some now unused functions
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from a design of "one compartment has one mapping" to "one compartment can be mapped multiple times". This involves "staging" a compartment, with temporary internal relative relocations, after which the staging can be lifted to a "mapping", which has correct relocations and can be executed. This greatly reduces the overhead of creating the same compartment multiple times.