Introduce a symbols API #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Sep 17, 2024
src/compartment.c
Outdated
| = find_lib_dep_sym_in_comp(curr_rela_map->rela_name, | ||
| new_comp, i, curr_rela_map->rela_sym_type, true); | ||
| // TODO Hack to suppress weak `libc` relocations | ||
| if (strcmp(new_comp->libs[i]->lib_name, "libc.so.7")) |
There was a problem hiding this comment.
Should we make this a bit more abstract e.g. at least "if name starts with libc.so" (i.e. without the ".7")?
There was a problem hiding this comment.
I would've liked to expand this into providing a list of libraries to suppress, or parameterise it, but maybe that's too much at this point, but at least I did the prefix check for libc.so in be0d58b.
|
Please squash. |
Rework how we store and search symbols for relocation, abstracting away most of the detail, in order to be able to use various underlying data types. As relocation seems to take most of the runtime based on initial observations, this is a first step in order to compare against various backend data types, rather than using an ad-hoc implementation.
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework how we store and search symbols for relocation, abstracting away most of the detail, in order to be able to use various underlying data types. As relocation seems to take most of the runtime based on initial observations, this is a first step in order to compare against various backend data types, rather than using an ad-hoc implementation.