Parameterised compartments #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `CompConfig` struct, which contains parameterisable values for compartment properties. Currently this includes only the heap and stack sizes, as well as entry points. The parameters are taken from the `.comp` TOML config file, similar to how entry points are determined. Enable `lua_suite_some` test, which runs a few hand-picked tests from the Lua test suite, just to see if we can find any other parts of Lua that need further handling in the manager. NOTE `gc.lua` *should* work, but it seems to take 10 hours on a virtualised CHERI instance. I think it might be due to the unoptimised memory allocator implementation, but that would need further benchmarking. Additionally refactor some old code, including getting rid of `CompEntryPoint` in favour of the singular `CompEntryPointDef` struct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
CompConfigstruct, which contains parameterisable values for compartment properties. Currently this includes only the heap and stack sizes, as well as entry points. The parameters are taken from the.compTOML config file, similar to how entry points are determined.Enable
lua_suite_sometest, which runs a few hand-picked tests from the Lua test suite, just to see if we can find any other parts of Lua that need further handling in the manager.NOTE
gc.luashould work, but it seems to take 10 hours on a virtualised CHERI instance. I think it might be due to the unoptimised memory allocator implementation, but that would need further benchmarking.Additionally refactor some old code, including getting rid of
CompEntryPointin favour of the singularCompEntryPointDefstruct.