Add TLS support #28
Merged
Add TLS support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Jun 3, 2024
ltratt
reviewed
Jun 3, 2024
ltratt
reviewed
Jun 3, 2024
src/compartment.c
Outdated
| if (to_map->libs[i]->tls_data_size != (size_t) -1) | ||
| { | ||
| assert(to_map->libs[i]->tls_sec_addr); | ||
| // TODO why 4? |
There was a problem hiding this comment.
I, uh, don't know. It seems to work with sizeof(void*), so I changed the question now to "Why sizeof(void*). This might be related to why printf doesn't work, but can't say without some in-depth debugging.
There was a problem hiding this comment.
Alright, managed to uncover and fix an issue with subsequent library TLS regions (as I hinted) in f47b3c9. This was also part of that fix.
ltratt
reviewed
Jun 3, 2024
|
I think this is ready for squashing? |
|
Let me just double check the last unresolved comment, maybe I can figure out why it works with both 4 and |
|
Please squash. |
Initial support for `_Thread_local` (and `_Thread_local static`) variables. Limitations: * Supports a single TLS region, but amenable to future extensions if we want to implement multi-threaded compartments; * Handles only symbols of type `TLSDESC`. Other changes: * Remove some old `struct Compartment` member variables that are now unneeded; * Add `print_comp` back; * Fix a bug regarding calculating scratch memory size for compartments; * Fixed a bug with setting relocation target addresses.
0152la
force-pushed
the
actual-printf-not-2
branch
from
b2830ff to
dacb4af
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for
_Thread_local(and_Thread_local static) variables.Limitations:
TLSDESC.Other changes:
struct Compartmentmember variables that are now unneeded;print_compback;