Internal malloc and various improvements
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow I missed this one -- sorry! |
ltratt
reviewed
Apr 22, 2024
|
bd73088 says "Remove some currently not working tests" but it adds two tests and removes none? |
|
Please squash. |
|
Squashed. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@0152la I guess the new commit fixes things and this can be squashed? If so, please squash. |
|
I wanted to do a bit further testing before going forward with this PR, in case anything else slipped through the cracks. I'll either squash it, or push further commits, based on how it goes. |
|
Ready for review. |
|
Please squash. |
* Provide a `malloc` and friends compartment library to be used internally, overriding the previous interception implementation. We use the DDC capability to get the are of memory that is designated as heap space. This is done in a new library, `libcomputils.so`, to be loaded in a compartment. This means further libraries loaded will also use our own internal `malloc` implementation; * Due to the above change, we also remove old intercept stuff, as that has been completely outdated by newer features (might come back for inter-compartment calls); * Fix setting improper bounds for compartment DDC capabilities (i.e., ensure the capability encompasses only the memory region designated for a compartment), and now set the offset to match the start of the compartment heap, to use for internal `malloc`; * Further improve symbol relocation lookup, including support for "raw" relocations that refer only to addresses, not to a given symbol.
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this has quite a bit of changes, including lots of removals, I decided to open the PR as multiple commits, to make reviewing easier.
mallocand friends compartment library to be usedinternally, overriding the previous interception implementation. We
use the DDC capability to get the are of memory that is designated as
heap space. This is done in a new library,
libcomputils.so, to beloaded in a compartment. This means further libraries loaded will also
use our own internal
mallocimplementation;code is meant to be rechecked and reworked at some point;
ensure the capability encompasses only the memory region designated
for a compartment), and now set the offset to match the start of the
compartment heap, to use for internal
malloc;