Improve eager symbol relocation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were improperly distinguishing object symbols versus function symbols by looking at the type of the relocation. We now use the type of the underlying symbol to know precisely whether we're relocating an object or a function. Furthermore, we now also consider symbol binding, in two situations: * It is fine for a WEAK bound symbol to not have a relocation - we emit a warning when this is the case, and do relocate if a symbol is available, but some weird artifacts (e.g., `_Jv_RegisterClasses`, which seems to be some Java stuff and would do some extra work if it were to exist) do not seem to have definitions; * We only eagerly relocate against GLOBAL bound symbols, not against LOCAL ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were improperly distinguishing object symbols versus function symbols by looking at the type of the relocation. We now use the type of the underlying symbol to know precisely whether we're relocating an object or a function.
Furthermore, we now also consider symbol binding, in two situations:
_Jv_RegisterClasses, which seems to be some Java stuff and would do some extra work if it were to exist) do not seem to have definitions;