Eager object symbol relocation #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Mar 5, 2024
| // TODO at least right now | ||
| if (!strcmp(&dyn_str_tbl[curr_rela_sym.st_name], "environ")) | ||
| { | ||
| continue; |
There was a problem hiding this comment.
Should we print warnings for these, or will they fail in some nice determinstic way if someone uses them?
There was a problem hiding this comment.
It's likely these will crash if used, although I haven't tested it. For now, I've added warnings to avoid using them in 13fcebd.
|
Please squash. |
Looking around in `printf`, we noticed it didn't work as objects were not being relocated across libraries. This PR enables this relocation; as well as adding a few extra tests. TODOs: * we do not properly handle GLOBAL vs LOCAL relocations; it might be a small optimization to ensure we hold the two symbol types in different containers, so that when we do relocate, we don't needlessly look around at LOCAL bound symbols; * WEAK bound symbols aren't relocated; * some of the added tests are currently not fully workingm mainly due to (we believe) WEAK bound symbols, which are planned to be fixed shortly.
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking around in
printf, we noticed it didn't work as objects were not being relocated across libraries. This PR enables this relocation; as well as adding a few extra tests.TODOs: