Implement transitive eager relocation #20
Conversation
|
Apparently saying "closes #[issue]" (or other keywords) instead of "handles #[issues]" automatically will be closing the linked issue. Horrifying, but cool. |
| do_pread(lib_fd, &curr_shdr, sizeof(Elf64_Shdr), | ||
| lib_ehdr.e_shoff + i * sizeof(Elf64_Shdr)); | ||
|
|
||
| if (curr_shdr.sh_type == SHT_SYMTAB) |
There was a problem hiding this comment.
I think this is unlikely, or maybe impossible, but what if there are two sections of the same type (e.g. SHT-SYMTAB)?
There was a problem hiding this comment.
I cry For now, things will break horribly. I would need to see an actual example to try to understand what would happen practically. I'll need to read and see if it's possible to produce such a binary. I think this would be beyond the current PR, however. I will at least have a read around for now to see, and then update.
There was a problem hiding this comment.
Looking at the ELF specification 1, page 66 (Book III, page 1-2) suggests that there can only be one SHT_SYMTAB, SHT_DYNSYM, and SHT_DYNAMIC (at least for now). I will also assume there can only be one section named .rela.plt. Therefore it seems your original assumption is (currently) impossible. I added a comment saying as such in 344cce8.
Footnotes
|
Please squash. |
We now gather all symbols to be relocated from all `so` libraries within a compartment, and perform eager relocation at map time. This means, primarily, that we handle each `so` file within a compartment the same, then perform a sweep to relocate required symbols after parsing and mapping. Other small changes: * Improve and add more `simple` tests, to test more specific functionality; * Some overall code refactoring; * Add `-Wextra`, and fix more warnings
0152la
force-pushed
the
transitive_eager_relo
branch
from
344cce8 to
1c2d2c9
Compare
|
Squashed. |
We now gather all symbols to be relocated from all
solibraries within a compartment, and perform eager relocation at map time. This means, primarily, that we handle eachsofile within a compartment the same, then perform a sweep to relocate required symbols after parsing and mapping. This closes #15.Other small changes:
simpletests, to test more specific functionality;-Wextra, and fix more warnings