Remove static ELF binary support #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltratt
reviewed
Feb 8, 2024
src/compartment.c
Outdated
| assert(new_comp->elf_type == ET_DYN || new_comp->elf_type == ET_EXEC); | ||
| if (new_comp->elf_type != ET_DYN) | ||
| { | ||
| errx(1, "Only supporting DYN ELF types!"); |
There was a problem hiding this comment.
I guess this means "Only DYN ELF is supported"?
There was a problem hiding this comment.
Yes, as per the Type property in readelf -h. Should I reword?
|
Please squash. |
Since we moved to supporting dynamic `so` ELFs, support for static ELFs has likely been broken. For code quality, we currently remove code that handle static ELFs, as well as intercepts that were introduced primarily for use with static ELFs.
0152la
force-pushed
the
static_cleanup
branch
from
18f6c8f to
0283343
Compare
|
Squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we moved to supporting dynamic
soELFs, support for static ELFs has likely been broken. For code quality, we currently remove code that handle static ELFs, as well as intercepts that were introduced primarily for use with static ELFs.