Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some renames and cleanup #18

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

0152la
Copy link
Contributor

@0152la 0152la commented Feb 8, 2024

  • Rename ConfigEntryPoint -> CompEntryPointDef
  • struct entry_point > struct CompEntryPoint
  • Rename other snake_case structs to PascalCase
  • compartment->comp_fns > compartment->comp_eps
  • Rethink filename manipulation to get compartment config file name; should fix some potential leaks

This was originally the compartment config information parsing overhaul I wanted to do from #14, but it seems most of that has been done in #13, so it became a bit of a clean-up / rename PR.

* Rename `ConfigEntryPoint` -> `CompEntryPointDef`
* `struct entry_point` > `struct CompEntryPoint`
* Rename other snake_case `struct`s to PascalCase
* `compartment->comp_fns` > `compartment->comp_eps`
* Rethink filename manipulation to get compartment config file name;
  should fix some potential leaks
@0152la 0152la requested a review from ltratt February 8, 2024 11:19
@ltratt ltratt added this pull request to the merge queue Feb 8, 2024
Merged via the queue into capablevms:master with commit 4db7d4d Feb 8, 2024
2 checks passed
@0152la 0152la deleted the comp_config_rework branch February 8, 2024 11:32
@0152la 0152la mentioned this pull request Feb 8, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants