Adding support for chunked transfers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +56,27 @@ class RequestAccessLogger(ctx: RequestContext, accessLogger: AccessLogger, | |||
| accessLogger.logAccess(request, response, timeStampCalculator(Unit)) | |||
| forwardMsgAndStop(response) | |||
| } | |||
| case Confirmed(ChunkedResponseStart(response), sentAck) => { | |||
There was a problem hiding this comment.
is it safe to assume these will always be Confirmed?
ie sent via responder ! MessageChunk.withAck(sentAck)?
There was a problem hiding this comment.
could re-write this case as:
case confirmed@Confirmed(ChunkResponseStart(response), _) => {
chunkedResponse = response
responder forward confirmed
}
There was a problem hiding this comment.
Changed & covers now also un-ACKed
|
Added |
Chunked transfers are not handled properly and time out while the transfer is still ongoing. With this patchset, each messageChunk is considered a heart beat and resetting the timeout scheduler.
| case confirmed@Confirmed(ChunkedResponseStart(response), _) => handleChunkedResponseStart(confirmed, response) | ||
| case unconfirmed@ChunkedResponseStart(response) => handleChunkedResponseStart(unconfirmed, response) | ||
|
|
||
| case confirmed@(Confirmed(MessageChunk(_,_), _) | MessageChunk) => { |
|
FWIW I'm 👍 |
This commit adds a connection abort in case of a timeout happens during a chunked transfer: A reasonable tear down and/or sending any content to the client is impossible as we have already started to transmit data. Thus it is impossible to predict how a client would treat any 'appened' error message to the stream anyway - and trailing headers are not supported by any reasonable HTTP client library out there. Therefore the connection is just aborted to get back to a "definied state".
passing values back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunked transfers are not handled properly and time out while the transfer is still ongoing.
With this patchset, each messageChunk is considered a heart beat and resetting the timeout scheduler.